✨ OPRUN-4151: Add webhook rule validation #2226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
perdasilva
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2226 +/- ##
==========================================
- Coverage 72.17% 72.07% -0.11%
==========================================
Files 85 85
Lines 8407 8423 +16
==========================================
+ Hits 6068 6071 +3
- Misses 1939 1950 +11
- Partials 400 402 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Oh, whoops, I need to sub out the olmv0 api group with the olmv1 one |
perdasilva
force-pushed
the
webhook-rule-validation
branch
from
77e4d47 to
5ac96d1
Compare
camilamacedo86
approved these changes
Sep 18, 2025
pedjak
reviewed
Sep 18, 2025
internal/operator-controller/rukpak/render/registryv1/validators/validator.go
Outdated
Show resolved
Hide resolved
internal/operator-controller/rukpak/render/registryv1/validators/validator.go
Outdated
Show resolved
Hide resolved
internal/operator-controller/rukpak/render/registryv1/validators/validator.go
Outdated
Show resolved
Hide resolved
internal/operator-controller/rukpak/render/registryv1/validators/validator.go
Outdated
Show resolved
Hide resolved
perdasilva
force-pushed
the
webhook-rule-validation
branch
from
5ac96d1 to
08d46c3
Compare
pedjak
reviewed
Sep 18, 2025
internal/operator-controller/rukpak/render/registryv1/validators/validator.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
perdasilva
force-pushed
the
webhook-rule-validation
branch
from
f51aaea to
35a98fc
Compare
added 2 commits
September 19, 2025 09:48
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
perdasilva
force-pushed
the
webhook-rule-validation
branch
from
35a98fc to
d42452a
Compare
pedjak
approved these changes
Sep 19, 2025
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, pedjak, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit d3e8883
into
operator-framework:main
25 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I recently discovered another boundary for webhook support [link] around the api groups and resources defined in the rules.
This PR adds that check to the bundle validator.
Reviewer Checklist